From faf5ca77dd38afcf3a4355966fba35ac6afb9632 Mon Sep 17 00:00:00 2001
From: Davo <info@davidmiklus.cz>
Date: Sat, 8 Oct 2022 19:55:12 +0200
Subject: [PATCH] revison 2.0

---
 README.md         | 38 ++++++++++++++++++++++++++++++++++++++
 defaults/main.yml |  2 ++
 handlers/main.yml |  2 +-
 tasks/main.yml    | 19 +++++++++----------
 4 files changed, 50 insertions(+), 11 deletions(-)
 create mode 100644 README.md
 create mode 100644 defaults/main.yml

diff --git a/README.md b/README.md
new file mode 100644
index 0000000..b359bb9
--- /dev/null
+++ b/README.md
@@ -0,0 +1,38 @@
+Ansible role for deploy node-exporter packages and services. You can add custom services or packages via variables bellow.
+
+This role is developed with Ansible 2.9.6 and tested on Ubuntu 20.04 LTS.
+
+## Role Variables
+
+| Variable | Required | Default | Comments |
+| -------- | -------- | ------- | -------- |
+| `additional_ports` | No | `{}` | Add aditional ports while using this role |
+
+## Requirements
+
+Ansible.posix collection
+
+To install it, use the following command:
+
+```yaml
+ansible-galaxy collection install ansible.posix
+```
+
+## Install basic packages and services with default settings
+```yaml
+  roles:
+     - sw-node-exporter
+```
+
+## Install basic packages and services with some custom variables
+```yaml
+  roles:
+     - sw-node-exporter
+  vars:
+     - additional_ports:
+        - 80/tcp
+        - 443/tcp
+        - 25565/udp
+```
+
+
diff --git a/defaults/main.yml b/defaults/main.yml
new file mode 100644
index 0000000..72ad890
--- /dev/null
+++ b/defaults/main.yml
@@ -0,0 +1,2 @@
+---
+additional_ports: {}
diff --git a/handlers/main.yml b/handlers/main.yml
index d00f0c2..104cf19 100644
--- a/handlers/main.yml
+++ b/handlers/main.yml
@@ -4,5 +4,5 @@
     daemon_reload: yes
 - name: firewalld reload
   ansible.builtin.systemd:
-    state: restarted
+    state: reloaded
     name: firewalld
diff --git a/tasks/main.yml b/tasks/main.yml
index 8dd0d8f..3df5b3b 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -20,7 +20,7 @@
     enabled: yes
     daemon_reload: yes
 
-- name: sw-node-exporter | PRE - 4. Allow ports in firewalld
+- name: sw-node-exporter | PRE - 4. Allow SPOLECNY ports in firewalld
   ansible.posix.firewalld:
     port: "{{ item }}"
     permanent: yes
@@ -30,15 +30,14 @@
     - 9100/tcp
     - 22/tcp
 
-# Muze byt pridano vice portu pomoci variablu, tedy alespon myslim, ale abych si nic nero*esral, tak je to takto.
-#- name: sw-node-exporter | PRE - 4. Allow ports in firewalld
-#  ansible.posix.firewalld:
-#    port: "{{ item }}"
-#    permanent: yes
-#    state: enabled
-#  notify: reload firewalld
-#  with_items: "{{ additional_ports }}"
-#  when: additional_ports is defined
+- name: sw-node-exporter | PRE - 4. Allow additional ports in firewalld
+  ansible.posix.firewalld:
+    port: "{{ item }}"
+    permanent: yes
+    state: enabled
+  notify: reload firewalld
+  with_items: "{{ additional_ports }}"
+  when: additional_ports is defined
 
 - name: sw-node-exporter | 1. Download and Unarchive node-exporter in /usr/local/bin
   ansible.builtin.unarchive: